Hopbot log for 2009-04-06 - Helma IRC channel: #helma on irc.freenode.net

2009-04-06:

[9:06] <hannesw> made a jetty6 branch with decke's patch:
[9:07] <hannesw> http://dev.helma.org/trac/helma/browser/helma/helma/branches/jetty6
[9:07] <hannesw> some things still missing unfortunately, most important being tobi's xml configuration feature.
[15:08] <hannesw> decke: I created a branch with your patch:
[15:08] <hannesw> http://dev.helma.org/trac/helma/browser/helma/helma/branches/jetty6
[15:09] <decke> hannesw: i've already seen it :o)
[15:09] <decke> so all further patches are against that branch ... and i will continue working on it today...
[15:09] <hannesw> the biggest remaining problem is the url constructor of jettyserver:
[15:09] <hannesw> http://dev.helma.org/trac/helma/browser/helma/helma/branches/jetty6/src/helma/main/JettyServer.java#L47
[15:10] <hannesw> because url is supposed to be a configuration file url.
[15:10] <hannesw> i changed a few things in applicationmanager, i think everything looks good there
[15:10] <decke> mhm and how did jetty 5.1 that?
[15:11] <hannesw> jetty 5 had a Server constructor that takes a URL as argument.
[15:11] <hannesw> couldn't find that in jetty 6.
[15:11] <decke> ah okay so that was an jetty xml config file?
[15:11] <hannesw> yep
[15:12] <decke> okay i will try to find a replacement ..
[15:12] <decke> and the getContext() / addContext()
[15:13] <hannesw> in JettyServer? I don't know, do we need them?
[15:13] <hannesw> i think we needed them in applicationmanager, but they're not used anymore, so no problem.
[15:13] <decke> i hoped you could answer that question...
[15:14] <hannesw> if they aren't used anymore we can lose them.
[15:14] <hannesw> the only other thing that would be nice is the ajp13 remote servers...
[15:14] <decke> yep but there was no quick replacement ...
[15:15] <decke> so about the same as the xml thing
[15:17] <hannesw> if we can implement those two features we can merge this for helma 1.7.
[15:17] <decke> hannesw: am i right here with the xml thing? http://jetty.mortbay.org/jetty5/tut/XmlConfiguration.html
[15:17] <hannesw> yes, i think this is it.
[15:18] <decke> puh they have a lot of xml config files...
[15:23] <decke> hannesw: xml thing is solved... http://docs.codehaus.org/display/JETTY/Embedding+Jetty
[15:23] <hannesw> cool
[15:24] <hannesw> I'm on a different branch right now.
[15:24] <decke> yeah i'll create a patch...
[15:25] <decke> just checking out the jetty6 right now...
[16:26] <decke> hannesw: does not look good with AJP remote hosts...
[16:27] <decke> Ajp13SocketConnector contains a line: Log.info("AJP13 is not a secure protocol. Please protect port {}",Integer.toString(getLocalPort()));
[16:28] <hannesw> so?
[16:28] <hannesw> can we protect it or not?
[16:28] <decke> the jetty6 listener can't
[16:29] <decke> we can write a patch against jetty...
[16:31] <decke> or tell the users that they have to be carefully on what IP they bind their AJP13 connector
[17:07] <decke> hannesw: or i can write a Filter and put it into the chain to filter out all bad AJP13 requests

 

 

In the channel now:

Logs by date: